Invalid manifest reference results in successful build


#1

Hello,

I wanted to build on an older manifest tag FROM resin/raspberrypi2-debian:jessie-20180411 , but it wasn’t found. I’ve done this in the past, so what am I doing wrong?
https://hub.docker.com/r/resin/raspberry-pi2-debian/tags/

Further, it seems like the builder does not fail and accepts the commit, which seems not right.
https://dashboard.resin.io/apps/137570/releases/496079

[Info]  Dashboard link: https://dashboard.resin.io/apps/137570/devices
[Info]  Building on arm01
[Info]  Pulling previous images for caching purposes...
[Success]  Successfully pulled cache images
[main]  Step 1/14 : FROM resin/raspberrypi2-debian:jessie-20180411
[main]  manifest for resin/raspberrypi2-debian:jessie-20180411 not found
[Success]  Release successfully created!
[Info]  ┌─────────┬────────────┬────────────┐
[Info]  │ Service │ Image Size │ Build Time │
[Info]  ├─────────┼────────────┼────────────┤
[Info]  │ main    │ 0 bytes    │ < 1 second │
[Info]  └─────────┴────────────┴────────────┘
[Info]  Build finished in 41 seconds

...

To git.resin..../....git
   2d9e631..2fc1acf  master -> master

#4

I think I solved my initial question. I’m using resin/raspberrypi2-debian and the documentation references resin/raspberry-pi2-debian which I didn’t notice.

I now notice the repository deprecation notice in the builder, but since I don’t normally look there, would it be possible to output this in the final build messages so it’s more visible?

[main]  Step 1/1 : RUN echo 'This repository is deprecated. Please check https://docs.resin.io/runtime/resin-base-images/ for information about Resin docker images.'
[main]   ---> Running in c2f1379d0ded

#5

Hi,
This seems useful.
I’ve added this to the list of features to consider.
Thanks for your suggestion.


#6

Thanks! However, I consider the builder behavior a bug also: i.e. a non-existent tag results in a successful build. Do you agree?


#7

Hi @exposedwiring your correct, this is unexpected behaviour, I’ll report the bug on our issue queue for the builder.


#8

@exposedwiring I’ve been unable to reproduce the bug on my machine, could you please provide your Dockerfile so I can create a minimal reproduction. If you don’t want to post it publicly you can send it to me in a private message.


#9

Sure, it should be as simple as referencing a non-existent Docker tag like this. The build fails on that line but is considered successful:

FROM resin/raspberrypi2-debian:jessie-20180411

Here’s the build log for release 2fc1acf3dab3f0367fd35838c25ef801555afc40:
https://dashboard.resin.io/apps/137570/releases/496079

If this matters, the previously successful build used FROM resin/raspberrypi2-debian:latest. Does this help?


#11

@exposedwiring thanks for the extra info, I’m able to reproduce the bug by running the build with FROM resin/raspberrypi2-debian:latest first, and then running a build with the incorrect tag…


#16

Hey, in this above you seem to mix two things up: first you refer to resin/raspberrypi2-debian, but then link to resin/raspberry-pi2-debian… Which one are you trying to use?

The no-hyphen one is obsolete and doesn’t have that tag, the second one is the correct, but it’s not what you are using in the FROM statement…

Sorry, should have read the whole thread, not just the beginning and end…